[SERVER-53075] annotate: drem because it is a ghost Created: 25/Nov/20  Updated: 10/Dec/20  Resolved: 08/Dec/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Josh Soref Assignee: Katya Kamenieva
Resolution: Won't Do Votes: 0
Labels: pull-request
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Query 2020-12-28
Participants:

 Description   

Remove references to "drem" as it seems to no longer exist.

Original Description

https://github.com/mongodb/mongo/blob/038338603c41475f97b5919e3f6365f6163f12c5/src/mongo/db/geo/geoparser.cpp#L93

https://jira.mongodb.org/browse/SERVER-11176

 

https://github.com/mongodb/mongo/commit/38c0eb538d0fd390c6cb9ce9ae9894153f6e8ef5

https://jira.mongodb.org/browse/SERVER-28004

 



 Comments   
Comment by Katya Kamenieva [ 10/Dec/20 ]

jsoref@gmail.com, I'm sorry to hear you feel that way. While not every PR is accepted, we believe that our team triages every one of them diligently, regardless of the size.  

Comment by Josh Soref [ 08/Dec/20 ]

Frankly, it does discourage me.

I have a much larger series of changes which I'd consider contributing, but if you aren't even willing to consider this one, I have a hard time believing you'd consider taking something bigger from me.

Comment by Katya Kamenieva [ 08/Dec/20 ]

Hi jsoref@gmail.com, thank you for pointing out this outdated comment. After consideration, we concluded that the suggested change is not significant enough to justify the merge process.
I hope this decision will not discourage you from contributing to the MongoDB codebase, and we will see PRs from you in the future.

Comment by Josh Soref [ 25/Nov/20 ]

https://github.com/mongodb/mongo/pull/1383

There is precisely one instance of `drem` in the codebase at this time. The comment referred to a function call that was removed.

At the very least, the comment should be clarified to talk about an actual function call in the codebase.

Possibly the removal of the function from the codebase may invite revisiting the code that introduced the comment.

Comment by Edwin Zhou [ 25/Nov/20 ]

Hi jsoref@gmail.com,

Could you please clarify the bug or issue you're seeing and their relationship with the tickets, commit, and code you linked?

Kindly,

Edwin

Generated at Thu Feb 08 05:29:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.