[SERVER-53127] Let AggregationRequestHelper::parseFromBSON() return an AggregateCommand Created: 30/Nov/20  Updated: 29/Oct/23  Resolved: 09/Feb/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: Ruoxin Xu Assignee: Sam Mercier
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-51649 Convert aggregate command input to IDL Closed
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: Query 2021-01-25, Query Optimization 2021-02-22
Participants:
Linked BF Score: 17

 Description   

AggregationRequestHelper::parseFromBSON() is used to create AggregateCommand. Currently it returns an AggregateCommand with Status. Since all the callers just uassert() it, it can just return an AggregateCommand and throw any error within the function.



 Comments   
Comment by Githook User [ 08/Feb/21 ]

Author:

{'name': 'samontea', 'email': 'merciers.merciers@gmail.com', 'username': 'samontea'}

Message: SERVER-53127 Let AggregationRequestHelper::parseFromBSON() return an AggregateCommand
Branch: master
https://github.com/mongodb/mongo/commit/6a5e743910ad6b2d9aea53aae046b2a0b63d3198

Comment by Githook User [ 08/Feb/21 ]

Author:

{'name': 'samontea', 'email': 'merciers.merciers@gmail.com', 'username': 'samontea'}

Message: SERVER-53127 Let AggregationRequestHelper::parseFromBSON() return an AggregateCommand
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/9d37aa3a79a3fe25b0b94cc9d384aea8b4fbd73d

Comment by Githook User [ 06/Feb/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: Revert "SERVER-53127 Let AggregationRequestHelper::parseFromBSON() return an AggregateCommand"

This reverts commit 6feae12fe29a4c921bdbf03dd8b1ae6d5dd27f92.
Branch: master
https://github.com/mongodb/mongo/commit/d77297f4a454073505741ae586c885e087b30165

Comment by Githook User [ 06/Feb/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: Revert "SERVER-53127 Let AggregationRequestHelper::parseFromBSON() return an AggregateCommand"

This reverts commit 71373ac59beb87526210f8be12e4cd6c14e45865.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/b7922a6071b24e09dbc4be50c25741f6a7f41b55

Comment by Githook User [ 06/Feb/21 ]

Author:

{'name': 'samontea', 'email': 'merciers.merciers@gmail.com', 'username': 'samontea'}

Message: SERVER-53127 Let AggregationRequestHelper::parseFromBSON() return an AggregateCommand
Branch: master
https://github.com/mongodb/mongo/commit/6feae12fe29a4c921bdbf03dd8b1ae6d5dd27f92

Comment by Githook User [ 06/Feb/21 ]

Author:

{'name': 'samontea', 'email': 'merciers.merciers@gmail.com', 'username': 'samontea'}

Message: SERVER-53127 Let AggregationRequestHelper::parseFromBSON() return an AggregateCommand
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/71373ac59beb87526210f8be12e4cd6c14e45865

Generated at Thu Feb 08 05:30:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.