[SERVER-53127] Let AggregationRequestHelper::parseFromBSON() return an AggregateCommand Created: 30/Nov/20 Updated: 29/Oct/23 Resolved: 09/Feb/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Ruoxin Xu | Assignee: | Sam Mercier |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Query 2021-01-25, Query Optimization 2021-02-22 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 17 | ||||||||||||
| Description |
|
AggregationRequestHelper::parseFromBSON() is used to create AggregateCommand. Currently it returns an AggregateCommand with Status. Since all the callers just uassert() it, it can just return an AggregateCommand and throw any error within the function. |
| Comments |
| Comment by Githook User [ 08/Feb/21 ] |
|
Author: {'name': 'samontea', 'email': 'merciers.merciers@gmail.com', 'username': 'samontea'}Message: |
| Comment by Githook User [ 08/Feb/21 ] |
|
Author: {'name': 'samontea', 'email': 'merciers.merciers@gmail.com', 'username': 'samontea'}Message: |
| Comment by Githook User [ 06/Feb/21 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: Revert " This reverts commit 6feae12fe29a4c921bdbf03dd8b1ae6d5dd27f92. |
| Comment by Githook User [ 06/Feb/21 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: Revert " This reverts commit 71373ac59beb87526210f8be12e4cd6c14e45865. |
| Comment by Githook User [ 06/Feb/21 ] |
|
Author: {'name': 'samontea', 'email': 'merciers.merciers@gmail.com', 'username': 'samontea'}Message: |
| Comment by Githook User [ 06/Feb/21 ] |
|
Author: {'name': 'samontea', 'email': 'merciers.merciers@gmail.com', 'username': 'samontea'}Message: |