[SERVER-53150] Specify input/output to isMaster/hello command in IDL Created: 01/Dec/20  Updated: 29/Oct/23  Resolved: 01/Mar/21

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: Samyukta Lanka Assignee: Sara Golemon
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-53160 Convert isMaster/hello command implem... Closed
Documented
is documented by DOCS-14291 Investigate changes in SERVER-53150: ... Closed
Problem/Incident
Related
is related to SERVER-51369 Add "variant" type to IDL syntax Closed
is related to SERVER-51358 Clearly indicate "awaitable" operatio... Backlog
Backwards Compatibility: Major Change
Sprint: Security 2021-02-08, Security 2021-02-22, Security 2021-03-08
Participants:
Linked BF Score: 47

 Description   

This work resulted in both the hello and isMaster commands now rejecting unknown fields.



 Comments   
Comment by Sara Golemon [ 01/Mar/21 ]

Reclosing as the reverted bits only needed to exist for support of the awaitable field which was removed entirely so there's no re-commit to do here.

Comment by Githook User [ 25/Feb/21 ]

Author:

{'name': 'Tyler Seip', 'email': 'Tyler.Seip@mongodb.com', 'username': 'tseip-mongo'}

Message: SERVER-51358: Revert "SERVER-51358: Indicate awaitable operations explicitly" and a small part of "SERVER-53150: Specify input/output to hello command"

This reverts commit 26ecc0880280ada1b9f77b3f07544843e50e3088.
Branch: master
https://github.com/mongodb/mongo/commit/4fc5efba5a232906fa0d9702e3b650bdf353a382

Comment by Githook User [ 10/Feb/21 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-53150 Specify input/output to hello command
Branch: master
https://github.com/mongodb/mongo/commit/87bcb24f50b65e08eb0d711edfb59b61ef3c1f91

Comment by Githook User [ 10/Feb/21 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: Revert "SERVER-53150 Specify input/output to hello command"

This reverts commit 92dfc822d41714b47bc20e260aafb54884909acc.
Branch: master
https://github.com/mongodb/mongo/commit/0dc7dd13c6b5d99d6c22d44f7ef96750f3540e50

Comment by Sara Golemon [ 10/Feb/21 ]

This change makes the hello command strict, meaning that passing unknown fields to the hello command will result in errors.

Comment by Githook User [ 10/Feb/21 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-53150 Specify input/output to hello command
Branch: master
https://github.com/mongodb/mongo/commit/92dfc822d41714b47bc20e260aafb54884909acc

Generated at Thu Feb 08 05:30:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.