[SERVER-53260] s2: remove definition of MSG_NOSIGNAL to fix macosx build Created: 07/Dec/20  Updated: 29/Oct/23  Resolved: 08/Dec/20

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service arch 2020-12-14
Participants:

 Description   

s2 base/port.h defines MSG_NOSIGNAL on macos, assuming MacOS doesn't have its own definition of it. Well, these days MacOS does, so this should be removed from s2.

s2 doesn't even use this definition, it's just pasted from a very old Google base/port.h header.



 Comments   
Comment by Githook User [ 08/Dec/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-53260 s2geometry: remove unused definition MSG_NOSIGNAL to fix macosx build
Branch: master
https://github.com/mongodb/mongo/commit/77349b0a9478efd7b8ccf1b4a928b83efc923858

Comment by Billy Donahue [ 08/Dec/20 ]

CR https://mongodbcr.appspot.com/719020001/

Generated at Thu Feb 08 05:30:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.