[SERVER-53289] Add additional coverage for flag-guarded features. Created: 08/Dec/20  Updated: 29/Oct/23  Resolved: 21/Jan/21

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.9.0-alpha3

Type: Improvement Priority: Major - P3
Reporter: Tess Avitabile (Inactive) Assignee: Cristopher Stauffer
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-53944 Remove core_sbe and aggregation_sbe t... Closed
is related to SERVER-51970 Create feature flag for Slot-based ex... Closed
is related to SERVER-52158 Create feature flag for Resharding Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

The "disabled feature flags" variant only provides coverage for Shared Library Enterprise RHEL 6.2. Several flag-guarded features benefit from coverage on other variants during development, such as ASAN, UBSAN, Windows (as an example of a slower machine that reveals timing bugs in distributed systems), and s390x (as an example of a big endian system that is needed for testing slot-based execution). We should consider how to provide coverage on more variants for flag-guarded features.



 Comments   
Comment by Githook User [ 24/Jan/21 ]

Author:

{'name': 'Cristopher Stauffer', 'email': 'cristopher.stauffer@mongodb.com', 'username': 'stauffec'}

Message: SERVER-53289: Adjusting time for all feature flags variants
Branch: master
https://github.com/mongodb/mongo/commit/0f6db4983bd3c05b75ec5cb41f804620f3c2d7b4

Comment by Githook User [ 24/Jan/21 ]

Author:

{'name': 'Cristopher Stauffer', 'email': 'cristopher.stauffer@mongodb.com', 'username': 'stauffec'}

Message: SERVER-53289: Adjusting time for all feature flags variants
Branch: master
https://github.com/mongodb/mongo/commit/9f501fa2129f9260d468aba956fac8e80d2e98dd

Comment by Cristopher Stauffer [ 21/Jan/21 ]

Also added:

~ Shared Library ASAN Enterprise Ubuntu 18.04 DEBUG (all feature flags)
~ Shared Library UBSAN Enterprise Ubuntu 18.04 DEBUG (all feature flags)
Enterprise RHEL 7.2 s390x (all feature flags)
 
 
 

Comment by Githook User [ 21/Jan/21 ]

Author:

{'name': 'Cristopher Stauffer', 'email': 'cristopher.stauffer@mongodb.com', 'username': 'stauffec'}

Message: SERVER-53289: Adding debug sanitizers and s390x for all feature flags
Branch: master
https://github.com/mongodb/mongo/commit/80deb6d3a24f6cb3bf60fbce16f7004a259ce99e

Comment by Githook User [ 12/Jan/21 ]

Author:

{'name': 'Cristopher Stauffer', 'email': 'cristopher.stauffer@mongodb.com', 'username': 'stauffec'}

Message: SERVER-53289: Updating names of feature flag variants to all-feature-flags
Branch: master
https://github.com/mongodb/mongo/commit/48eb1af51e8e0ba7abaf4c5cdf9c06a959a7722d

Comment by Githook User [ 12/Jan/21 ]

Author:

{'name': 'Cristopher Stauffer', 'email': 'cristopher.stauffer@mongodb.com', 'username': 'stauffec'}

Message: SERVER-53289: Adding non-required Windows builder and required sanitizer builder for full feature flag testing
Branch: master
https://github.com/mongodb/mongo/commit/4bc913878acdaef88a9aa2cac11ec6dc609cd910

Comment by Githook User [ 12/Jan/21 ]

Author:

{'name': 'Cristopher Stauffer', 'email': 'cristopher.stauffer@mongodb.com', 'username': 'stauffec'}

Message: SERVER-53289: Adding non-required Windows builder and required sanitizer builder for full feature flag testing
Branch: master
https://github.com/mongodb/mongo/commit/9c5499ea820a58a1dc7c6cfc883d29fbe86f9f4a

Comment by Cristopher Stauffer [ 12/Jan/21 ]

Added variants:
! Enterprise Windows (disabled feature flags) 
* Enterprise Windows (disabled feature flags) 
! Shared Library {A,UB}SAN Enterprise Ubuntu 18.04 DEBUG (disabled feature flags)

Comment by Githook User [ 12/Jan/21 ]

Author:

{'name': 'Cristopher Stauffer', 'email': 'cristopher.stauffer@mongodb.com', 'username': 'stauffec'}

Message: SERVER-53289: Adding required variant for feature flag disabled for Windows
Branch: master
https://github.com/mongodb/mongo/commit/bc25963c7ed654b4d476f2259aaff9057f7bad49

Generated at Thu Feb 08 05:30:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.