[SERVER-53292] removal of util/printable_enum.h ? Created: 09/Dec/20  Updated: 29/Oct/23  Resolved: 04/Jan/21

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service arch 2020-12-28
Participants:

 Description   

I just ran across this new header while looking for something else. I want to discuss actually upgrading its 2 call sites by removing it.

This looks like a niche thing used in db/cst/ and put into util/, which is crowded.

It's a macro library, and what it does feels pretty specific to the needs of that project, and doesn't feel like it's going to be a good fit for util/.

Something similar was done in db/audit/action_types and it is really not so bad to rewrite it on the spot and get more flexible semantics.



 Comments   
Comment by Ian Whalen (Inactive) [ 04/Jan/21 ]

Author:

{'username': u'evrg-bot-webhook', 'name': u'Billy Donahue', 'email': u'billy.donahue@mongodb.com'}

Message:SERVER-53292 db/query/util/named_enum.h
Branch:master
https://github.com/mongodb/mongo/commit/6aa68e89ef4a394287fd588c3694dc089096ea69

Comment by Billy Donahue [ 09/Dec/20 ]

https://mongodbcr.appspot.com/748110010/

Generated at Thu Feb 08 05:30:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.