[SERVER-53340] Merge DocumentSourceGroup::MemoryUsageTracker with GroupStats Created: 14/Dec/20  Updated: 23/Dec/20  Resolved: 23/Dec/20

Status: Closed
Project: Core Server
Component/s: Aggregation Framework, Diagnostics
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Rishab Joshi (Inactive) Assignee: Rishab Joshi (Inactive)
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-53461 totalDataSizeGroupedBytesEstimate sta... Closed
Operating System: ALL
Sprint: Query 2020-12-14, Query 2021-01-11
Participants:

 Description   

We have nested structure called MemoryUsageTracker inside DocumentSourceGroup, which tracks memory related statistics. 

Ticket 48380 introduced GroupStats in the file src/mongo/db/exec/plan_stats.h

While working on this CR, I moved 2 fields from MemoryUsageTracker, namely, memoryUsageBytes and usedDisk to GroupStats. 

I did not moved all the fields of MemoryUsageTracker to GroupStats taking into consideration that exposing all fields might not be required.

But, having 2 separate structure to track the stats of DocumentSourceGroup is also not legible.

 

As part of this ticket, we should attempt to revisit MemoryUsageTracker's stats and see if we can move more field to the GroupStats. And if possible, get rid of MemoryUsageTracker all together.

 

Commit details for your reference: https://github.com/mongodb/mongo/commit/62a3ca9041393dca40273ff935677c686cfa7fbb 

 

 



 Comments   
Comment by Rishab Joshi (Inactive) [ 23/Dec/20 ]

Will do merging where applicable in the ticket SERVER-53461, as both are related to DocumentSourceGroup.

Generated at Thu Feb 08 05:30:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.