[SERVER-53359] jstestfuzz (mutational) fuzzer is forcing last-lts FCV during validate instead of latest Created: 14/Dec/20 Updated: 29/Oct/23 Resolved: 15/Jan/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0, 4.4.5 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Max Hirschhorn | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||||||||||||||||||||||
| Sprint: | Execution Team 2021-01-25 | ||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 47 | ||||||||||||||||||||||||||||||||||||||||
| Description |
|
The changes from It appears we forgot to change 4.2 -> 4.4 in the jstestfuzz*.yml test suites during the 4.4 release cycle. Observe that both the 4.2 and 4.4 branches are currently forcing the FCV to 4.2. Instead, the 4.4 branch should be forcing the feature compatibility version to 4.4. This hasn't been an issue because there isn't a difference in validate behavior on 4.4, and that'll likely be why the skipFCV concept from b45c07c as part of However, this in turn led us to change 4.2 -> 4.4 in c593d0f as part of |
| Comments |
| Comment by Githook User [ 17/Feb/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit fc1ee1497f904fc9d6a25813f5d012292af32a14) | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 17/Feb/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit c15915dac6c5fbdd35616a58d88e324d7261a424) | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 16/Feb/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}Message: (cherry picked from commit 8cd628682a3db3a1ec97b884d876f4c6e9343ff8) | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 19/Jan/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 15/Jan/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 15/Jan/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}Message: | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Max Hirschhorn [ 13/Jan/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Another option to avoid manually updating the jstestfuzz*.yml YAML suite files after each major release would be to change TestData.forceValidationWithFeatureCompatibilityVersion to TestData.forceValidationWithLatestFCV because that's the only way it is used. Then jstests/hooks/run_validate_collections.js and jstests/hooks/validate_collections.js can refer to the latestFCV variable that's compiled into the mongo shell without needing to use eval(). | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Max Hirschhorn [ 14/Dec/20 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
The following changes would enable the jstestfuzz*.yml YAML suite files to refer to the latestFCV constant compiled into the mongo shell so we don't need to manually update them after each major release. It requires the collection validation hook allowing TestData.forceValidationWithFeatureCompatibilityVersion to be eval()'d instead of being interpreted as a constant string literal value.
|