[SERVER-53409] refresh some names in FailPoint implementation Created: 16/Dec/20 Updated: 29/Oct/23 Resolved: 22/Jan/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Service arch 2020-12-28, Service Arch 2021-02-08 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
In order to understand FailPoint's block open and close behavior, I found it very helpful to rename several internal entities and reduce the RetCode enum. The diff was too big for the ticket it was originally written for and was reverted in the interest of reviewer mercy, but here it is. https://mongodbcr.appspot.com/748170001/#ps719300001 I think a standalone review just focusing on that patch would be very beneficial. FailPoint has grown up a lot and some of these names don't cleanly apply. |
| Comments |
| Comment by Githook User [ 21/Jan/21 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 23/Dec/20 ] |