[SERVER-53580] restore const qualifiers to arguments in test function definitions Created: 05/Jan/21  Updated: 29/Oct/23  Resolved: 13/Jan/21

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Improvement Priority: Minor - P4
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-51240 Add clang tidy rules to prevent const... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2021-01-25
Participants:

 Description   

In SERVER-51240, we removed the const qualifier from a number of function arguments in some of our unit tests - the clang-tidy rule that motivated this change is more of a check on the function declaration rather than the definitions - it is still ok, even meaningful because it communicates how the function argument is used, to retain some of the const qualifiers in the function definitions.



 Comments   
Comment by Githook User [ 13/Jan/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-53580 restore const qualifiers to arguments in function definitions
Branch: master
https://github.com/mongodb/mongo/commit/11908a3840a43b7a58126eb38644863b5c0b20f6

Generated at Thu Feb 08 05:31:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.