[SERVER-53721] Race in failpoint tenantMigrationHangDuringCollectionClone Created: 12/Jan/21  Updated: 29/Oct/23  Resolved: 14/Jan/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Lingzhi Deng Assignee: Lingzhi Deng
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Sprint: Repl 2021-01-25
Participants:
Linked BF Score: 17

 Description   

This failpoint is error-prone. It is very hard to use it correctly because we check the conditions for the failpoint in TenantCollectionCloner::insertDocumentsCallback. But multiple calls of TenantCollectionCloner::insertDocumentsCallback for different batches could run in parallel because it's scheduled on an executor. So there could be races when using this failpoint together with a small collectionClonerBatchSize because the check for the failpoint's conditions may not align with the batch boundaries.

I think we can delete this failpoint but use tenantMigrationHangCollectionClonerAfterHandlingBatchResponse instead.



 Comments   
Comment by Githook User [ 13/Jan/21 ]

Author:

{'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}

Message: SERVER-53721: Delete failpoint tenantMigrationHangDuringCollectionClone
Branch: master
https://github.com/mongodb/mongo/commit/7482ea7be38855cba135b743a5a8a6d0d663626f

Generated at Thu Feb 08 05:31:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.