[SERVER-53744] Fix build on FreeBSD/powerpc64le Created: 13/Jan/21  Updated: 29/Oct/23  Resolved: 11/Feb/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 5.0 Desired
Fix Version/s: 4.9.0

Type: Improvement Priority: Major - P3
Reporter: Piotr Kubaj Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: pull-request
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to WT-8473 Power8 vector intrinsic CRC32 impleme... Closed
Backwards Compatibility: Fully Compatible
Sprint: Dev Platform 2021-01-25, Dev Platform 2021-02-08, Dev Platform 2021-02-22
Participants:

 Description   

Changes done:

  1. Add registers for R01_sig and R32_sig on FreeBSD/powerpc64le.
  2. Add mozjs config and source files.
  3. Rename src/checksum/power8/crc32.sx to src/checksum/power8/crc32.S.
    The reason is that Clang refuses to build .sx files and needs .S for assembly.
    This should also help building with Clang on other operating systems.
  4. Clang doesn't have ppc-asm.h header. When building with Clang, use the
    bundled ppc-asm.h file from GCC (this is what upstream at https://github.com/antonblanchard/crc32-vpmsum does).
    This should also help building with Clang on other operating systems.
Original Description

MongoDB currently supports only Linux on ppc64le architecture. Supporting FreeBSD is trivial and has been implemented in https://github.com/mongodb/mongo/pull/1390

It's already committed in FreeBSD ports tree in databases/mongodb40, databases/mongodb42 and databases/mongodb44 ports.



 Comments   
Comment by Githook User [ 11/Feb/21 ]

Author:

{'name': 'Piotr Kubaj', 'email': 'pkubaj@FreeBSD.org', 'username': 'pkubaj'}

Message: SERVER-53744 Fix build on FreeBSD/powerpc64le.

Changes done:
1. Patch MozJS registers for R01_sig and R32_sig on FreeBSD/powerpc64le.
2. Add stanza for ppc64le/freebsd to extract script.

Signed-off-by: Andrew Morrow <acm@mongodb.com>

Closes #1390
Branch: master
https://github.com/mongodb/mongo/commit/f4b7d9465834ab88e25190088512c1a46131b57d

Comment by Andrew Morrow (Inactive) [ 11/Feb/21 ]

pkubaj@anongoth.pl - I just submitted your change to our CI system, so this should merge in the next few hours. Thanks for contributing to MongoDB!

Comment by Andrew Morrow (Inactive) [ 08/Feb/21 ]

pkubaj@anongoth.pl - I had the PR ready to merge but thought of one last question. I think the answer is that it is good to go as is, but could you please follow up on the PR?

Comment by Andrew Morrow (Inactive) [ 01/Feb/21 ]

pkubaj@anongoth.pl - Hey, are you still interested in moving this forward? I left some comments on the PR.

Generated at Thu Feb 08 05:31:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.