[SERVER-53759] Remove DocumentSource::usedDisk() Created: 13/Jan/21  Updated: 06/Dec/22

Status: Backlog
Project: Core Server
Component/s: Aggregation Framework
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: David Storch Assignee: Backlog - Query Execution
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Execution
Participants:

 Description   

The DocumentSource::usedDisk() virtual method must be implemented by any agg stage which can spill to disk, such as $group or $sort, to indicate whether spilling to disk actually occurred at runtime. This seems like an overly specific virtual method to exist on DocumentSource, the aggregation's abstract concept for any runtime query execution stage. Further, we have since extended DocumentSource to support a more generic execution stats reporting interface which closely resembles that used by both the classic execution engine and the slot-based execution engine. In particular, we now have DocumentSource::getCommonStats() and DocumentSource::getSpecificStats(). As a simplification of the code, and an improvement of the DocumentSource interface, we should consolidate usedDisk() with these more generic agg execution stats methods and delete usedDisk().


Generated at Thu Feb 08 05:31:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.