[SERVER-53763] SSLManagerWindows::initSSLContext() support for transientParams, same for MacOS Created: 13/Jan/21  Updated: 20/Apr/21  Resolved: 19/Jan/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Andrew Shuvalov (Inactive) Assignee: Andrew Shuvalov (Inactive)
Resolution: Won't Fix Votes: 0
Labels: WIndows, macos, pm-1791_milestone-P
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
causes SERVER-52858 Server-side MacOS and Windows SSL con... Closed
Related
is related to SERVER-56100 Ban tenant migration tests from macOs... Closed
Sprint: Sharding 2021-01-25
Participants:
Linked BF Score: 39

 Description   

The support for transient params was not implemented because of difficulties with testing, as in https://jira.mongodb.org/browse/SERVER-52858. However as this ticked is closed, the support should be added. It was my mistake to not file this ticket together with test problem.

Code link: https://github.com/mongodb/mongo/blob/fee631bc61d2fc85bd727967cfb4f2f243395461/src/mongo/util/net/ssl_manager_windows.cpp#L1346.



 Comments   
Comment by Andrew Shuvalov (Inactive) [ 19/Jan/21 ]

Quick fix submitted.

Next, I'm disabling the tenant migration tests on Windows. Quick fix submitted as in comments, better fix in new https://jira.mongodb.org/browse/SERVER-53883 

Comment by Githook User [ 16/Jan/21 ]

Author:

{'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}

Message: SERVER-53763: disable tenenat migration tests on Windows because of SSL limitations
Branch: master
https://github.com/mongodb/mongo/commit/282d3eaa3eb53faacb5d4a52ad204086afedf7ea

Comment by Andrew Shuvalov (Inactive) [ 15/Jan/21 ]

What we will do now is just stop the tenant migration tests on Windows. I've made a temporary fix and will continue next week to actually disable this feature flag on Windows even after all feature flags will be on. As I'm not sure how to do it yet, it won't come today, but I will keep this bug open.

Comment by Andrew Shuvalov (Inactive) [ 15/Jan/21 ]

Please consider that it means the full support of transient SSL params is missing on Windows. If you think this has any completeness value I'm happy to fix the Windows code, in fact I already started working on this. I'll wait a day for the consensus one way or another.

Generated at Thu Feb 08 05:31:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.