[SERVER-53866] Investigate how write commands should inherit from IDL generated base Command class. Created: 19/Jan/21 Updated: 29/Oct/23 Resolved: 02/Mar/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Rishab Joshi (Inactive) | Assignee: | Rishab Joshi (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Query 2021-01-25, Query Execution 2021-02-22, Query Execution 2021-03-08 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
Investigate how write commands - insert/update/delete should inherit from IDL generated base Command class. |
| Comments |
| Comment by Githook User [ 02/Mar/21 ] |
|
Author: {'name': 'Rishab Joshi', 'email': 'rishab.joshi@mongodb.com', 'username': 'rishvin'}Message: |
| Comment by Samyukta Lanka [ 21/Jan/21 ] |
|
If we determine that they won't inherit from the IDL generated base class (which I think would be fine), we should make sure that the command still ensures that the request adheres to the spec outlined in IDL by parsing the request. Additionally, to be evaluated by the IDL Compatibility Checker script, we should add the api_version and reply_type fields to each command's IDL file. |