[SERVER-53968] Replace invariant with tassert in src/mongo/db/pipeline code Created: 22/Jan/21  Updated: 22/Jan/24

Status: Open
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Charlie Swanson Assignee: Backlog - Query Execution
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-73173 Replace invariant with tassert in src... Backlog
related to SERVER-73174 Replace invariant with tassert in Pla... Backlog
related to SERVER-73175 Replace invariant with tassert in upd... Backlog
is related to SERVER-73172 Replace invariant with tassert in src... Backlog
Assigned Teams:
Query Execution
Sprint: QE 2023-05-15, QE 2023-05-29, QE 2023-06-12, QE 2023-06-26, QE 2023-07-10, QE 2023-07-24, QE 2023-08-07, QE 2023-08-21, QE 2023-09-04, QE 2023-09-18, QE 2023-10-02, QE 2023-10-16, QE 2023-10-30, QE 2023-11-13, QE 2023-11-27, QE 2023-12-11, QE 2023-12-25, QE 2024-01-08, QE 2024-01-22
Participants:

 Description   

SERVER-44570 introduced tassert which should be better suited for most invariant statements scattered throughout the QE codebase. This ticket tracks the work to take a pass through and update where appropriate.



 Comments   
Comment by Steve Tarzia [ 10/Jan/23 ]

arun.banala@mongodb.com please help us by splitting this ticket so we can prioritize the areas where this can be feasibly corrected.

Comment by Steve Tarzia [ 10/Jan/23 ]

Note that tassert is slower than invariant, so we may not want to use tassert in very hot paths, or we can investigate doing what invariant does to be more efficient.

Comment by Arun Banala [ 05/Jan/23 ]

Flagging this for scheduling given that this should mostly be a cometic change, but the benefits for the customer are huge. We should probably split this into few tickets. I've filed SERVER-72417 specifically for projection code. The owner of this ticket can decide how they want to break the work. Probably we can have one ticket for classic Plan Stages, one for pipelines and one for SBE.

Generated at Thu Feb 08 05:32:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.