[SERVER-54031] errorcodes.py doesn't check embedded C++ code in Python scripts Created: 25/Jan/21 Updated: 29/Oct/23 Resolved: 06/Mar/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0, 4.4.5, 4.0.24, 4.2.14 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Eric Milkie | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v4.4, v4.2, v4.0
|
||||
| Sprint: | Service Arch 2021-03-08 | ||||
| Participants: | |||||
| Description |
|
We seem to have ended up with a duplicate assert code 40088 between these two places: I believe this is because buildscripts/errorcodes.py isn't looking in .py files, but it probably can be easily adapted to do so. This issue is important because we actually have a problem report from the field with this exact error code. |
| Comments |
| Comment by Githook User [ 11/Mar/21 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Githook User [ 11/Mar/21 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Githook User [ 11/Mar/21 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Githook User [ 06/Mar/21 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 25/Feb/21 ] |
| Comment by Billy Donahue [ 25/Feb/21 ] |
|
After looking at this with more time to reflect on it, it's easy enough to just do it. The errant python example is the only place where any .py file would match the patterns we scan for. I was a little worried that we might have other gen files or .yy files or .inl or whatever of this flavor. I do think we should add .idl files as well though since they can conceivably include c++ snippets of interest. I also noticed that the pattern we scan for will not handle the newer iassert or tassert macros. The get_all_source_files function doesn't need to be in buildscripts/utils.py. The only caller is errorcodes.py and bring it |