[SERVER-54091] Update assertion messages for dbhash check run by resmoke.py Created: 28/Jan/21  Updated: 29/Oct/23  Resolved: 01/Feb/21

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.9.0, 4.0.23, 4.2.13, 4.4.5

Type: Task Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Judah Schvimer
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4, v4.2, v4.0
Participants:

 Description   

Both run_check_repl_dbhash.js and run_check_repl_dbhash_background use the phrase "data consistency checks failed" in their assertion messages. However, these two assertion failing mean different things: run_check_repl_dbhash.js failing represents permanent data loss and run_check_repl_dbhash_background.js failing typically represents transient incorrect query results (specifically around reading at a timestamp).

There is a desire to have an automated system distinguish these two cases from the assertion messages alone. This ticket is to update one or both of these files so the hooks fail with different assertion messages than each other. (One should probably also not be a substring of the other either.) This ticket must be backported all the way to the 4.0 branch—when run_check_repl_dbhash_background.js was first introduced—for the automated system to get the full benefit.



 Comments   
Comment by Githook User [ 17/Feb/21 ]

Author:

{'name': 'Judah Schvimer', 'email': 'judah@mongodb.com', 'username': 'judahschvimer'}

Message: SERVER-54091 Update assertion messages for dbhash check run by resmoke.py
Branch: v4.4
https://github.com/mongodb/mongo/commit/3deaf71cf31c4d688d9a71b23b8c91a2479dbf0a

Comment by Githook User [ 04/Feb/21 ]

Author:

{'name': 'Judah Schvimer', 'email': 'judah@mongodb.com', 'username': 'judahschvimer'}

Message: SERVER-54091 Update assertion messages for dbhash check run by resmoke.py

(cherry picked from commit cada2662c229b72329a7fed7bf6ebfbcc9f740e1)
Branch: v4.2
https://github.com/mongodb/mongo/commit/0431757da259bc5586d69477775319cb49346a0f

Comment by Githook User [ 03/Feb/21 ]

Author:

{'name': 'Judah Schvimer', 'email': 'judah@mongodb.com', 'username': 'judahschvimer'}

Message: SERVER-54091 Update assertion messages for dbhash check run by resmoke.py
Branch: v4.0
https://github.com/mongodb/mongo/commit/37f0a1170e98263a012d466bc0c4f63c1232e44f

Comment by Githook User [ 01/Feb/21 ]

Author:

{'name': 'Judah Schvimer', 'email': 'judah@mongodb.com', 'username': 'judahschvimer'}

Message: SERVER-54091 Update assertion messages for dbhash check run by resmoke.py
Branch: master
https://github.com/mongodb/mongo/commit/cada2662c229b72329a7fed7bf6ebfbcc9f740e1

Generated at Thu Feb 08 05:32:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.