[SERVER-54122] Fix fuzzer_tests bug of setting requireApiVersion to true and not cleaning it. Created: 28/Jan/21  Updated: 29/Oct/23  Resolved: 05/Feb/21

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Moustafa Maher Assignee: Moustafa Maher
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-56925 Remove requireApiVersion server param... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2021-02-08, Repl 2021-02-22
Participants:
Linked BF Score: 9

 Comments   
Comment by Githook User [ 05/Feb/21 ]

Author:

{'name': 'Moustafa Maher', 'email': 'm.maher@10gen.com', 'username': 'moustafamaher'}

Message: SERVER-54122 Fix fuzzer_tests bug of setting requireApiVersion to true and not cleaning it.
Branch: master
https://github.com/mongodb/mongo/commit/31f2c01634171f89690e46ddb56584c1107d5b84

Comment by Moustafa Maher [ 01/Feb/21 ]

Problems going on with requireApiVersion and our tests:

1- There isn't any synchronization between mongo shell processes when running in the jstestfuzz_concurrent* test suites. this means one instance could still be executing its preamble when another instance changes the requireApiVersion server parameter

  • This isn’t fixable with the design of the concurrent fuzzer. the answer there may be to disallow the fuzzer from setting these server parameters when TestData.numTestClients > 1 Link 

 

2-  jstestfuzz_replication_initsync.yml is running the BackgroundInitialSync hook before it runs the FuzzerRestoreSettings hook Link, fuzzer test runs, sets requireApiVersion to a bad thing, BackgroundInitialSync runs validate/dbhash to check consistency

  • swapping the order of FuzzerRestoreSettings and BackgroundInitialSync in the hooks list may be sufficient. I peeked at Link and didn't see any comments indicating why it was added where it was.
Generated at Thu Feb 08 05:32:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.