[SERVER-54139] Remove CURL share support from HTTP curl client Created: 29/Jan/21 Updated: 29/Oct/23 Resolved: 01/Mar/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | 4.0.22, 4.4.3, 4.2.12 |
| Fix Version/s: | 4.9.0, 4.2.13, 4.4.5, 4.0.24 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Mark Benvenuto | Assignee: | Mark Benvenuto |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Operating System: | ALL | ||||||||||||||||
| Backport Requested: |
v4.4, v4.2, v4.0
|
||||||||||||||||
| Sprint: | Security 2021-02-22, Security 2021-03-08 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Case: | (copied to CRM) | ||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||
| Description |
|
libcurl's share feature, which is used for a shared connection cache, is not thread safe. This is typically used to support HTTP keep-alive connections. It needs to be removed to improved the stability of the HTTP client when used by multiple threads. This only affects queryable restore. It needs to be backported to all affected versions. The libcurl documentation (https://curl.se/libcurl/c/curl_share_setopt.html) states
which was added as part of https://github.com/curl/curl/issues/4915. This was originally added for |
| Comments |
| Comment by Shane Harvey [ 04/Aug/21 ] |
As shown in |
| Comment by Githook User [ 03/Mar/21 ] |
|
Author: {'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}Message: (cherry picked from commit fca01d31762e9271cb5e710901b93ec65baee3b7) |
| Comment by Githook User [ 03/Mar/21 ] |
|
Author: {'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}Message: (cherry picked from commit 137bd47d9138fe9bbb0e1fc81dfbbce2cfd35a96) |
| Comment by Githook User [ 02/Mar/21 ] |
|
Author: {'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}Message: |
| Comment by Githook User [ 01/Mar/21 ] |
|
Author: {'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}Message: (cherry picked from commit fca01d31762e9271cb5e710901b93ec65baee3b7) |
| Comment by Githook User [ 01/Mar/21 ] |
|
Author: {'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}Message: (cherry picked from commit 137bd47d9138fe9bbb0e1fc81dfbbce2cfd35a96) |
| Comment by Githook User [ 01/Mar/21 ] |
|
Author: {'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}Message: |
| Comment by Githook User [ 23/Feb/21 ] |
|
Author: {'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}Message: |