[SERVER-54192] Each query parser initializer set should be grouped by a single initializer that depends on "default" Created: 01/Feb/21  Updated: 29/Oct/23  Resolved: 25/May/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: David Percy Assignee: Anton Korshunov
Resolution: Fixed Votes: 0
Labels: quick-tech-debt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
is duplicated by SERVER-54133 Group DocumentSource Initializers Closed
Problem/Incident
is caused by SERVER-51454 operationProfiling.filter config opti... Closed
Related
is related to SERVER-54133 Group DocumentSource Initializers Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Query Optimization 2021-05-31
Participants:

 Description   

Currently all of the register expression initializers depend on a single initializer, so things that need to go before expressions can depend on that. We should do the same thing for document sources.

When we register a parser using REGISTER_DOCUMENT_SOURCE, REGISTER_EXPRESSION, etc, we need to make sure the initializer declares its dependency on the "default" initializer. The "default" initializer is responsible for initializing serverGlobalParams, which we depend on for FCV and feature flags. We should make the grouped initializer responsible for this dependency.

Usually the MONGO_INITIALIZER macro handles this, but we are using MONGO_INITIALIZER_GENERAL in at least one place (to declare reverse-dependencies).



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 25/May/21 ]

Author:

{'name': 'Anton Korshunov', 'email': 'anton.korshunov@mongodb.com', 'username': 'antkorsh'}

Message: SERVER-54192 Each query parser initializer set should be grouped by a single initializer that depends on "default"
Branch: master
https://github.com/mongodb/mongo/commit/a488cf175a1cf85a05c1d50c1ccbbbc09bfdb00e

Comment by Githook User [ 25/May/21 ]

Author:

{'name': 'Anton Korshunov', 'email': 'anton.korshunov@mongodb.com', 'username': 'antkorsh'}

Message: SERVER-54192 Each query parser initializer set should be grouped by a single initializer that depends on "default"
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/842be7b571474374b650746c54708bf31918bd58

Generated at Thu Feb 08 05:32:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.