[SERVER-54198] --ninja builds should automatically set CCFLAGS=-fdiagnostics-color Created: 02/Feb/21  Updated: 06/Dec/22  Resolved: 04/Feb/21

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Mathias Stearn Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-47115 Enable colorized compiler output for ... Closed
Assigned Teams:
Server Development Platform
Operating System: ALL
Participants:

 Description   

Ninja captures and buffers stdout and stderr from builds (except when pool=console) which tricks the istty check in compilers. The recommendation from https://github.com/ninja-build/ninja/wiki/FAQ is to add -fdiagnostics-color to the compile flags. Ninja adds its own istty checks and will filter out the color codes if the output isn't a terminal, so it isn't harmful to add the flag always, even when ninja output is redirected.


Generated at Thu Feb 08 05:32:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.