[SERVER-54210] add clang-tidy to commit queue tasks Created: 02/Feb/21 Updated: 29/Oct/23 Resolved: 16/Mar/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | David Bradford (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Sprint: | DAG 2021-03-22 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
The clang-tidy task has a very minimal set of rules that has been useful in detecting programming errors since it was introduced in |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 18/Feb/21 ] |
|
I'm not sure you really need two tickets - the act of renaming it to be a required builder will automatically add it to the commit queue, if I understand the current setup correctly. |
| Comment by Brooke Miller [ 18/Feb/21 ] |
|
david.bradford will create a ticket to add this task to the required builder before we do this ticket. |
| Comment by Andrew Morrow (Inactive) [ 08/Feb/21 ] |
|
I don't think we have any particular hard rule on when things become required. I think it went in as suggested because it was new and we perhaps didn't want to require a revert on failure. If we do want to require a revert on failure, and prevent that from happening, then I think it could be bumped up to required. I think the server leads need to decide if they like that or not. |
| Comment by David Bradford (Inactive) [ 08/Feb/21 ] |
|
acm Do you know why it is not already a required builder? It looks like it is already being run on an `xlarge` instance, so moving to a large instance probably won't help. |
| Comment by Brooke Miller [ 08/Feb/21 ] |
|
We've reassigned this to DAG to evaluate whether or not this task should be added, FYI david.bradford. Also, robert.guo mentioned that If the current time it takes to run the task is too long, we should try to run this on a large instance. (See linked |
| Comment by Andrew Morrow (Inactive) [ 02/Feb/21 ] |
|
Note that if we do this, we should promote the clang-tidy from being -suggested to being -required. |