[SERVER-54228] Change ValidateResult from BasicCommandWithRequestParser to only throw in test mode Created: 03/Feb/21  Updated: 29/Oct/23  Resolved: 05/Feb/21

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: Moustafa Maher Assignee: Moustafa Maher
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Minor Change
Sprint: Repl 2021-02-08
Participants:

 Description   

The goal of validating the result of a command as part of enforcing "API Versioning" constraints is to catch any breaking changes in our code at testing phase, and not to block customers' runs.

 

So we need to make sure that we only throw validation exception in "Debug_mode" only.

We need to wrap this Line in if (getTestCommandsEnabled()) clause.



 Comments   
Comment by Githook User [ 05/Feb/21 ]

Author:

{'name': 'Moustafa Maher', 'email': 'm.maher@10gen.com', 'username': 'moustafamaher'}

Message: SERVER-54228 : Change ValidateResult from BasicCommandWithRequestParser to only throw in test mode
Branch: master
https://github.com/mongodb/mongo/commit/3cacfa01fb7c149893726e0481824ba458250c50

Generated at Thu Feb 08 05:32:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.