[SERVER-54394] Remove flag to avoid using snapshot read concern in ConfigServerCatalogCacheLoader on unit_tests Created: 08/Feb/21  Updated: 29/Oct/23  Resolved: 03/May/22

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Jordi Serra Torrens Assignee: Gregory Noma
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-48314 ephemeralForTest should support times... Closed
Problem/Incident
causes SERVER-66361 Address data race involving Replicati... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2022-05-16
Participants:

 Description   

In SERVER-54874 we modified the ConfigServerCatalogCache to refresh using an aggregation pipeline and snapshot read concern.

However, the ephemeral_for_test_kv_engine storage engine doesn't currently support snapshot read concern (SERVER-48314). The ShardingMongodTestFixture uses the ephimeralForTesting storage engine, so the unit tests that involved refreshing the cache with snapshot read concern would fail. Temporarily, to address this SERVER-53105 added a flag to avoid using snapshot read concern for the refresh and instead use localReadConcern. This flag is only enabled on unit tests.

This ticket is to remove this flag and use snapshotReadConcern in all cases. This can be done once SERVER-48314 is done. Alternatively, we could consider using the wiredTiger storage engine in ShardingMongodTestFixture.



 Comments   
Comment by Githook User [ 03/May/22 ]

Author:

{'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}

Message: SERVER-54394 Remove `setAvoidSnapshotForRefresh_ForTest`
Branch: master
https://github.com/mongodb/mongo/commit/fe08161c8c50c5fc2ea245ca248a7a05f9c3cdc6

Comment by Jordi Serra Torrens [ 08/Mar/21 ]

Reopening since as part of SERVER-54874 we refresh the catalog cache using an aggregation with snapshot read concern.

Comment by Jordi Serra Torrens [ 16/Feb/21 ]

Closing as 'Won't do' since in the end we did not implement the snapshot read in ConfigServerCatalogCache as part of SERVER-53105.

Generated at Thu Feb 08 05:33:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.