[SERVER-54484] resmoke/util/archival.py relies on deprecated and now removed thread.isAlive Created: 12/Feb/21 Updated: 29/Oct/23 Resolved: 16/Feb/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0, 4.2.13, 4.4.5 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v4.4, v4.2
|
||||
| Sprint: | Dev Platform 2021-02-22 | ||||
| Participants: | |||||
| Description |
|
Thread.isAlive was deprecated in python 3.8 and removed in 3.9, per https://bugs.python.org/issue37804 However, resmoke relies on it: https://github.com/mongodb/mongo/blob/eb2b72cf9c0269f086223d499ac9be8a270d268c/buildscripts/resmokelib/utils/archival.py#L290-L294 |
| Comments |
| Comment by Githook User [ 18/Feb/21 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: (cherry picked from commit d5beb490d241d0ad77e92aafe15fb6f270ea4dfe) |
| Comment by Githook User [ 16/Feb/21 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: (cherry picked from commit d5beb490d241d0ad77e92aafe15fb6f270ea4dfe) |
| Comment by Githook User [ 16/Feb/21 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: |
| Comment by Andrew Morrow (Inactive) [ 16/Feb/21 ] |
|
This fix is also trivial: replace calls to isAlive with is_alive: https://github.com/python/cpython/commit/89669ffe10a9db6343f6ee42239e412c8ad96bde |