[SERVER-54489] Full validation can append errors without bound Created: 12/Feb/21  Updated: 29/Oct/23  Resolved: 27/Apr/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.2.15, 4.4.7, 5.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Gregory Noma Assignee: Henrik Edin
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4, v4.2
Sprint: Execution Team 2021-04-05, Execution Team 2021-04-19, Execution Team 2021-05-03
Participants:

 Description   

SERVER-46468 addressed one case where it was possible to try to append too many errors to the validate response, causing the maximum BSON size limit to be exceeded. It appears there may be another case where something similar can occur, this time through WiredTigerUtil::verifyTable which is run only for full validation. It appears that this path has no bound on the number of errors that it can append.



 Comments   
Comment by Githook User [ 03/Jun/21 ]

Author:

{'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}

Message: SERVER-54489 Limit 'errors' and 'warnings' fields in validation result to 2MB each to reduce the probability to go over the size limit in the response.

(cherry picked from commit 3ba3ab4f46e939f9d428a511cb24b1d142dea534)
Branch: v4.2
https://github.com/mongodb/mongo/commit/97b91fd47ea9e3e4b0f5a5e1b9e21a41f13d522f

Comment by Githook User [ 19/May/21 ]

Author:

{'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}

Message: SERVER-54489 Limit 'errors' and 'warnings' fields in validation result to 2MB each to reduce the probability to go over the size limit in the response.

(cherry picked from commit 3ba3ab4f46e939f9d428a511cb24b1d142dea534)
Branch: v4.4
https://github.com/mongodb/mongo/commit/0d3eef72c7731b7d01a8acde1d4c0c15ac9ba99c

Comment by Githook User [ 27/Apr/21 ]

Author:

{'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}

Message: SERVER-54489 Limit 'errors' and 'warnings' fields in validation result to 2MB each to reduce the probability to go over the size limit in the response.
Branch: master
https://github.com/mongodb/mongo/commit/3ba3ab4f46e939f9d428a511cb24b1d142dea534

Generated at Thu Feb 08 05:33:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.