[SERVER-54517] Remove redundant 'shouldFail()' around pauseWhileSet() for hangAfterInitializingIndexBuild failpoint Created: 12/Feb/21  Updated: 29/Oct/23  Resolved: 12/Feb/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Jason Chan Assignee: Jason Chan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2021-02-22
Participants:
Linked BF Score: 17

 Description   

This is unintuitive when writing tests that use the 'hangAfterInitializingIndexBuild' fialpoint because shouldFail() and pauseWhileSet() both increment the 'timesEntered' counter by 1. This can lead to unintended races in our tests that rely on the failpoint 'waitForTimesEntered' command. We should remove the shouldFail since pauseWhileSet already does that check internally.



 Comments   
Comment by Githook User [ 12/Feb/21 ]

Author:

{'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}

Message: SERVER-54517 Remove redundant 'shouldFail()' around pauseWhileSet() for hangAfterInitializingIndexBuild failpoint
Branch: master
https://github.com/mongodb/mongo/commit/b8cd0ef00f5ef5cf978317cf4cee16ac100c860b

Generated at Thu Feb 08 05:33:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.