[SERVER-54517] Remove redundant 'shouldFail()' around pauseWhileSet() for hangAfterInitializingIndexBuild failpoint Created: 12/Feb/21 Updated: 29/Oct/23 Resolved: 12/Feb/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jason Chan | Assignee: | Jason Chan |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Sprint: | Repl 2021-02-22 | ||||
| Participants: | |||||
| Linked BF Score: | 17 | ||||
| Description |
|
This is unintuitive when writing tests that use the 'hangAfterInitializingIndexBuild' fialpoint because shouldFail() and pauseWhileSet() both increment the 'timesEntered' counter by 1. This can lead to unintended races in our tests that rely on the failpoint 'waitForTimesEntered' command. We should remove the shouldFail since pauseWhileSet already does that check internally. |
| Comments |
| Comment by Githook User [ 12/Feb/21 ] |
|
Author: {'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}Message: |