[SERVER-54528] Race between shutting down replica set and initial sync failing in initial_sync_fails_when_source_removed.js Created: 12/Feb/21  Updated: 29/Oct/23  Resolved: 17/Feb/21

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.9.0, 4.4.5

Type: Bug Priority: Major - P3
Reporter: Samyukta Lanka Assignee: Samyukta Lanka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Repl 2021-02-22
Participants:
Linked BF Score: 11

 Description   

We shut off this failpoint which was hanging initial sync before stopping the replica set. If the replication coordinator realized that the node was in shut down, the node will shut down fine. However, if the node is not in shut down when the initial sync attempt fails, it will fassert.

I think we should let shut down interrupt the failpoint instead of turning the failpoint off to make sure that the replication coordinator is aware of shutdown when the initial syncer finishes the attempt.



 Comments   
Comment by Githook User [ 08/Mar/21 ]

Author:

{'name': 'Samy Lanka', 'email': 'samy.lanka@mongodb.com', 'username': 'lankas'}

Message: SERVER-54528 Avoid race between initial sync failing and shutdown in initial_sync_fails_when_source_removed.js

(cherry picked from commit aaec1aab2980ad27f738c6f3bbc9bd186c4ef918)
Branch: v4.4
https://github.com/mongodb/mongo/commit/347e5cc5daf62be43c545f4071f250abefc9ebc3

Comment by Githook User [ 17/Feb/21 ]

Author:

{'name': 'Samy Lanka', 'email': 'samy.lanka@mongodb.com', 'username': 'lankas'}

Message: SERVER-54528 Avoid race between initial sync failing and shutdown in initial_sync_fails_when_source_removed.js
Branch: master
https://github.com/mongodb/mongo/commit/aaec1aab2980ad27f738c6f3bbc9bd186c4ef918

Comment by Samyukta Lanka [ 12/Feb/21 ]

code review: https://mongodbcr.appspot.com/756910044/

Generated at Thu Feb 08 05:33:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.