[SERVER-54578] MatchExpression::shallowClone() should be renamed Created: 16/Feb/21  Updated: 29/Oct/23  Resolved: 17/Mar/23

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Mathias Stearn Assignee: Amr Elhelw
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Execution
Backwards Compatibility: Major Change
Participants:

 Description   

The operation it performs is usually called a deep copy, so it is confusing every time I read it. Hopefully renaming it to either clone or deepClone will avoid that confusion for everyone in the future.



 Comments   
Comment by Githook User [ 16/Mar/23 ]

Author:

{'name': 'Amr Elhelw', 'email': 'amr.elhelw@mongodb.com', 'username': 'aelhelw'}

Message: SERVER-54578 Remove final traces of shallowClone()
Branch: master
https://github.com/mongodb/mongo/commit/17bd5ed609662c48ef82bb0db4bf1b2f1ddfe341

Comment by Githook User [ 14/Mar/23 ]

Author:

{'name': 'Ian Boros', 'email': 'ian.boros@mongodb.com', 'username': 'borosaurus'}

Message: SERVER-54578 Use optimistic fast path for generating keystrings
Branch: master
https://github.com/mongodb/mongo/commit/1d28f1258fa7a5d2741e5b1a77a810e58dc47480

Comment by Githook User [ 14/Mar/23 ]

Author:

{'name': 'Amr Elhelw', 'email': 'amr.elhelw@mongodb.com', 'username': 'aelhelw'}

Message: SERVER-54578 Rename MatchExpression::shallowClone() to MatchExpression::clone()
Branch: master
https://github.com/mongodb/mongo/commit/b97c66ded102f70b88bbcb2d75d7309dd73c0910

Generated at Thu Feb 08 05:33:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.