[SERVER-54600] enterprise: mark some classes final to silence xcode12 builds Created: 18/Feb/21  Updated: 29/Oct/23  Resolved: 20/Feb/21

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service Arch 2021-02-22
Participants:

 Description   

XCode12 can't build enterprise because it emits a warning about a number of classes in enterprise that have final destructors but are not themselves final classes.

 src/mongo/db/modules/enterprise/src/ldap/connections/openldap_connection.h:23:27: error: class with destructor marked 'final' cannot be inherited from [-Werror,-Wfinal-dtor-non-final-class]
 ~OpenLDAPConnection() final;
 ^
src/mongo/db/modules/enterprise/src/ldap/connections/openldap_connection.h:20:7: note: mark 'mongo::OpenLDAPConnection' as 'final' to silence this warning
class OpenLDAPConnection : public LDAPConnection {
 ^
1 error generated.



 Comments   
Comment by Githook User [ 19/Feb/21 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-54600 mark some classes final to silence xcode12 builds
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/4337496a0ea33dfceee8782406dd72048f4bb98a

Comment by Billy Donahue [ 18/Feb/21 ]

CR https://mongodbcr.appspot.com/745580034/

Generated at Thu Feb 08 05:33:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.