[SERVER-5461] Add syncSourceHost field to replSetGetStatus output Created: 30/Mar/12 Updated: 22/May/18 Resolved: 30/Apr/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 3.4.16, 3.6.6, 4.0.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kristina Chodorow (Inactive) | Assignee: | Suganthi Mani |
| Resolution: | Done | Votes: | 3 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||
| Backport Requested: |
v3.6, v3.4
|
||||||||||||||||||||||||||||||||
| Sprint: | Repl 2018-05-07 | ||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||
| Description |
|
The 'syncingTo' field in replSetGetStatus output is ambiguously named. To make it clear what direction the replication is going in, we will add a new field "syncSourceHost" with the same data as the existing "syncingTo". In a later version we will remove "syncingTo". |
| Comments |
| Comment by Githook User [ 22/May/18 ] |
|
Author: {'username': 'smani87', 'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com'}Message: (cherry picked from commit 649630d10bf6c00225480fe261c042737e5d9688) |
| Comment by Githook User [ 22/May/18 ] |
|
Author: {'username': 'smani87', 'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com'}Message: (cherry picked from commit 649630d10bf6c00225480fe261c042737e5d9688) |
| Comment by Githook User [ 27/Apr/18 ] |
|
Author: {'email': 'suganthi.mani@mongodb.com', 'username': 'smani87', 'name': 'Suganthi Mani'}Message: |
| Comment by Suganthi Mani [ 24/Apr/18 ] |
|
Code review url: http://mongodbcr.appspot.com/200350002 |
| Comment by Spencer Brody (Inactive) [ 23/Apr/18 ] |
|
Since we're adding a 'syncSourceId' field in |
| Comment by Daniel Pasette (Inactive) [ 02/Feb/16 ] |
|
This does not need to be backported at all. We should not make this change in a minor release version in any case. |
| Comment by Ben McCann [ 17/Aug/13 ] |
|
True, though mentioning it in the release notes as a breaking change and saving it for a major release version would mitigate a lot of that worry I would think. |
| Comment by Eliot Horowitz (Inactive) [ 17/Aug/13 ] |
|
Ben - its an easy change to make, but worried about breaking scripts/tools that expect that field. |
| Comment by Ben McCann [ 17/Aug/13 ] |
|
+1 syncingTo is extremely confusing and misleading. syncingFrom is much more indicative of what is happening. This should be a really easy change to make |
| Comment by Stennie Steneker (Inactive) [ 02/Nov/12 ] |
|
I suggest changing this to something that more clearly implies a configuration option rather than active "syncing", eg to match the rs command: syncFrom. A few customers have confused the new "syncingTo" message as an indication that nodes are somehow not in sync after upgrading to 2.2.x (despite a healthy node state of "SECONDARY" and no replication lag). |