[SERVER-54695] The --disable-warnings-as-errors flag should not affect configure checks Created: 22/Feb/21  Updated: 29/Oct/23  Resolved: 25/Mar/21

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 5.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Dev Platform 2021-03-22, Dev Platform 2021-04-05
Participants:

 Description   

The configure check subsystem relies on generating diagnostics to detect unsupported flags. One some platforms, this requires that -Werror be in play in order for those diagnostics to be fatal. However, the --disable-warnings-as-errors flag inhibits application of -Werror. This can result in configure checks returning surprising results. In particular, if a user has passed an invalid flag in by setting CCFLAGS or similar on the command line but has also applied --disable-warnings-as-errors, the build may proceed despite the erroneous flag. We should ensure that the effect of --disable-warnings-as-errors applies only to our source code, and not to our configure checks.



 Comments   
Comment by Githook User [ 25/Mar/21 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-54695 Disabling warnings as errors should not apply to configure checks by default
Branch: master
https://github.com/mongodb/mongo/commit/d25e6a800437f65ada43c9bc3502031d346cd128

Comment by Githook User [ 25/Mar/21 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: Revert "SERVER-54695 Disabling warnings as errors should not apply to configure checks by default"

This reverts commit 609d174c95fdfbc0193e1d7e8804ef20a04f99e1.
Branch: master
https://github.com/mongodb/mongo/commit/a49827ee30cf37844f177b587071b6b51db87c90

Comment by Githook User [ 24/Mar/21 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-54695 Disabling warnings as errors should not apply to configure checks by default
Branch: master
https://github.com/mongodb/mongo/commit/609d174c95fdfbc0193e1d7e8804ef20a04f99e1

Generated at Thu Feb 08 05:34:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.