[SERVER-54695] The --disable-warnings-as-errors flag should not affect configure checks Created: 22/Feb/21 Updated: 29/Oct/23 Resolved: 25/Mar/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Dev Platform 2021-03-22, Dev Platform 2021-04-05 |
| Participants: |
| Description |
|
The configure check subsystem relies on generating diagnostics to detect unsupported flags. One some platforms, this requires that -Werror be in play in order for those diagnostics to be fatal. However, the --disable-warnings-as-errors flag inhibits application of -Werror. This can result in configure checks returning surprising results. In particular, if a user has passed an invalid flag in by setting CCFLAGS or similar on the command line but has also applied --disable-warnings-as-errors, the build may proceed despite the erroneous flag. We should ensure that the effect of --disable-warnings-as-errors applies only to our source code, and not to our configure checks. |
| Comments |
| Comment by Githook User [ 25/Mar/21 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: |
| Comment by Githook User [ 25/Mar/21 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: Revert " This reverts commit 609d174c95fdfbc0193e1d7e8804ef20a04f99e1. |
| Comment by Githook User [ 24/Mar/21 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: |