[SERVER-54735] Executor shutdown can cause AsyncTry-until to set its result with ErrorCodes::BrokenPromise Created: 23/Feb/21  Updated: 29/Oct/23  Resolved: 10/Aug/21

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 5.0.3, 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Matthew Saltz (Inactive) Assignee: Amirsaman Memaripour
Resolution: Fixed Votes: 0
Labels: servicearch-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
related to SERVER-55176 Complete TODO listed in SERVER-54735 Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.0
Sprint: Service Arch 2021-03-22, Service Arch 2021-05-31, Service Arch 2021-06-14, Service Arch 2021-06-28, Service Arch 2021-07-12, Service Arch 2021-08-09, Service Arch 2021-08-23
Participants:
Linked BF Score: 124
Story Points: 3

 Description   

If the executor shuts down here, the continuation passed to getAsync will not run, leading the result promise to be set with a BrokenPromise error. We should fix it to set a ShutdownInProgress error in that case.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 11/Aug/21 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-54735 Make AsyncTry-Until loops set results to ShutdownInProgress on executor shutdown

(cherry picked from commit c9bd3836cef42d45a72dc881d59c667910824e36)
Branch: v5.0
https://github.com/mongodb/mongo/commit/f61900ad1db707ade9b7376a2ce8c4b189915526

Comment by Githook User [ 10/Aug/21 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-54735 Make AsyncTry-Until loops set results to ShutdownInProgress on executor shutdown
Branch: master
https://github.com/mongodb/mongo/commit/c9bd3836cef42d45a72dc881d59c667910824e36

Comment by Githook User [ 16/Mar/21 ]

Author:

{'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}

Message: Revert "SERVER-54735 Fix AsyncTry to not return BrokenPromise on executor shutdown in certain cases"

This reverts commit 51ced746d0d60a57109a61eb21ce9be506deb71d.
Branch: master
https://github.com/mongodb/mongo/commit/915e8558215edb7775f47324a719061d54d02f44

Comment by Githook User [ 11/Mar/21 ]

Author:

{'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}

Message: SERVER-54735 Fix AsyncTry to not return BrokenPromise on executor shutdown in certain cases
Branch: master
https://github.com/mongodb/mongo/commit/51ced746d0d60a57109a61eb21ce9be506deb71d

Generated at Thu Feb 08 05:34:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.