[SERVER-54785] Complete TODO listed in SERVER-52719 Created: 25/Feb/21  Updated: 29/Oct/23  Resolved: 17/Mar/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Jason Chan
Resolution: Fixed Votes: 0
Labels: autogen-todo, pm-1791_non-cloud-blocking, pm-1791_other_required
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-52719 Restart TenantMigrationRecipientServi... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2021-03-22
Participants:

 Description   

There is a TODO in the codebase referencing a resolved ticket which is assigned to you.

Please follow this link to see the lines of code referencing this resolved ticket:
https://github.com/mongodb/mongo/search?q=SERVER-52719&type=Code

The next steps for this ticket are to either remove the outdated TODO or follow the steps in the TODO if it is correct. If the latter, please update the summary and description of this ticket to represent the work you're actually doing.

 

Ticket update:

As part of removing the TODOs to enable testing, we found the following bug:

  1. Recipient exits the AsyncTry loop after fulfilling the data consistent promise.
  2. Donor sees that the promise is fulfilled by immediately fails over.
  3. Recipient detects donor failover and aborts the migration instead of retrying.

 

So as part of this ticket, we want to make sure we retry on donor failover in the above case. The solution is to move the following wait on the tenantOplogApplier into the AsyncTry and to also synchronize the following code in the case of concurrent shutdown of the oplog applier due to migration retry.



 Comments   
Comment by Githook User [ 17/Mar/21 ]

Author:

{'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}

Message: SERVER-54785 Complete TODO listed in SERVER-52719 and allow recipient to
retry on donor failover after data consistent
Branch: master
https://github.com/mongodb/mongo/commit/06ec07e0aab34e645fa116543afc88695d2d63dc

Generated at Thu Feb 08 05:34:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.