[SERVER-54871] Stop logging hooks to fixture logs Created: 01/Mar/21  Updated: 29/Oct/23  Resolved: 23/Mar/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Task Priority: Major - P3
Reporter: Raiden Worley (Inactive) Assignee: Siran Wang (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-52677 CheckReplDBHashInBackground output is... Closed
Backwards Compatibility: Fully Compatible
Sprint: STM 2021-03-22, STM 2021-04-05
Participants:
Story Points: 1

 Description   

Hook loggers have fixture loggers as parents, so when report.py overrides the logger with a newly-constructed testcase logger, the new logger double-logs to both the fixture logs and the the hook's dedicated test logs.

SERVER-52677 solved this for the CheckReplDBHashInBackground hook by using the testqueue logger, but we should expand the solution to other hooks.



 Comments   
Comment by Githook User [ 23/Mar/21 ]

Author:

{'name': 'Siran Wang', 'email': 'siran.wang@mongodb.com', 'username': 'vincivans'}

Message: SERVER-54871 update hook_test_case logger to avoid duplicate logs
Branch: master
https://github.com/mongodb/mongo/commit/9c3dd66796d5971fc3707c6ffd42c4059e501db9

Comment by Raiden Worley (Inactive) [ 01/Mar/21 ]

ryan.timmons pointed out in the CR for SERVER-52677 that the current logger the hooks use looks like the perfectly intuitive choice.

Now that the resmoke side of PM-1439 is wrapped up; we may want to consider more general logging cleanups as part of either this ticket or PM-1567. (At least something that removes the report.py override that makes the logger used in a testcase hard to predict.)

Generated at Thu Feb 08 05:34:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.