[SERVER-54927] Move away from using Bson_serialization_type “any” Created: 03/Mar/21  Updated: 29/Oct/23  Resolved: 25/Mar/21

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 5.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Moustafa Maher Assignee: Moustafa Maher
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Minor Change
Sprint: Repl 2021-03-22, Repl 2021-04-05
Participants:

 Description   

Using Bson_serialization_type “any” means that idl compatibility checker script can’t do any type checking, since that logic is in cpp, so we want to disallow this type from parameters/reply fields as a result.

However, lots of commands actually use it for valid reasons.
For now we added some exceptions to allow using Bson_serialization_type “any” in our idl_checker script, these are the lisf of fields that still using Bson_serialization_type “any” that require your attention:

src/mongo/db/repl/hello.idl

  1. The 'hello'' command has parameter 'saslSupportedMechs' that has type 'UserName' 

 

Take a look at these fields and try to identify which ones can be converted away from using Bson_serialization_type “any”, and which ones must keep using it.
Here are the two outcomes:
1- if the field can be converted:

  • This change should be done before 5.0 (if the field is "stable") as this will be the realese for API stable Version 1
  • The exception for that field should be removed from idl_checker script (TODO will be added with this ticket number).

2- if the field can't be converted, or the change can't be done before 5.0.

  • The type of that field type should stay of Bson_serialization_type “any” and can't be changed later for any reason unless it is defined as "unstable".
  • We need to put comments on the serialization/deserialization to prevent the behavioral changes (preferably to add tests to ensure that.)

 



 Comments   
Comment by Githook User [ 25/Mar/21 ]

Author:

{'name': 'Moustafa Maher', 'email': 'm.maher@10gen.com', 'username': 'moustafamaher'}

Message: SERVER-54927 move away from using Bson_serialization_type any
Branch: master
https://github.com/mongodb/mongo/commit/c4530deb51e0f97cc48c2547f915bb4b39e49253

Comment by Githook User [ 25/Mar/21 ]

Author:

{'name': 'moustafamaher', 'email': 'm.maher@mongodb.com', 'username': 'moustafamaher'}

Message: SERVER-54927 Move away from using Bson_serialization_type “any”
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/cbcb5c8a4dd22d8fc00a472df017001a05fda152

Generated at Thu Feb 08 05:34:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.