[SERVER-54975] Rename IDL parser classes to *CommandRequest Created: 04/Mar/21  Updated: 29/Oct/23  Resolved: 03/Apr/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Bernard Gorman Assignee: Bernard Gorman
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Query Execution 2021-03-22, Query Execution 2021-04-05, Query Execution 2021-04-19
Participants:

 Description   

Generally, we make a distinction in the server between the "command"
(which executes the requested logic, and inherits from the base Command class)
and the "request" (a parsed version of the command object received from the
user). For instance, we have historically maintained classes named AggregationRequest, QueryRequest, CountRequest, etc, as distinct from the Command classes which execute the associated commands.

Recently, we moved the parsing of several such command requests into the IDL; however, the class names generated by the IDL omit the Request suffix. This leads to a situation where the names of the request and execution classes are confusingly similar, e.g. at present we have FindCommand, FindCmd and ClusterFindCmd classes all in the mongo namespace.

We should consistently name the IDL parser classes *CommandRequest to distinguish the request parsers from the execution machinery.



 Comments   
Comment by Githook User [ 02/Apr/21 ]

Author:

{'name': 'Bernard Gorman', 'email': 'bernard.gorman@gmail.com', 'username': 'gormanb'}

Message: SERVER-54975 Rename IDL parser classes to use CommandRequest and CommandReply suffixes
Branch: master
https://github.com/mongodb/mongo/commit/ea51edf33aa685e8b8d4692ee42b8c0e8e9cfb98

Comment by Githook User [ 02/Apr/21 ]

Author:

{'name': 'Bernard Gorman', 'email': 'bernard.gorman@gmail.com', 'username': 'gormanb'}

Message: SERVER-54975 Rename IDL parser classes to use CommandRequest and CommandReply suffixes
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/4a5820a517d8d695b2f2cbedfffe9d6f380c1d01

Generated at Thu Feb 08 05:35:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.