[SERVER-55149] Remove wrong TODO on the drop collection coordinator Created: 11/Mar/21  Updated: 29/Oct/23  Resolved: 01/Apr/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: Backlog
Fix Version/s: 5.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Tommaso Tocci Assignee: Tommaso Tocci
Resolution: Fixed Votes: 0
Labels: PM-1965-Milestone-1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 2021-03-22
Participants:

 Description   

Currently we are unconditionally broadcasting the drop collection to all the shards also for un-sharded collections because of SERVER-33973. After 5.0 will became last LTS we can actually stop broadcasting to all the shards for the un-sharded collections.

As discussed with kaloian.manassiev we can't stop broadcasting even in 5.1 because some old drop collection run on an old binary (in which was broken) could have left garbage.



 Comments   
Comment by Githook User [ 01/Apr/21 ]

Author:

{'name': 'Tommaso Tocci', 'email': 'tommaso.tocci@mongodb.com', 'username': 'toto-dev'}

Message: SERVER-55149 Remove wrong TODO on the drop collection coordinator
Branch: master
https://github.com/mongodb/mongo/commit/26259c07c39c58d26b2f82fedca9c4b97263ee36

Comment by Kaloian Manassiev [ 20/Mar/21 ]

Yes, but we can do a movePrimary and that operation doesn't cleanup on failure either.

Comment by Tommaso Tocci [ 16/Mar/21 ]

kaloian.manassiev I believe you are right about "but also some guarantee that we have cleaned any leftover garbage up from previous versions". On the other hand since we are talking about un-sharded collection I don't think that your second requirement applies. In fact we can't move a chunk for an unsharded collection.

Comment by Kaloian Manassiev [ 16/Mar/21 ]

I think it might not actually be sufficient that 5.0 becomes LTS, but also some guarantee that we have cleaned any leftover garbage up from previous versions and also to guarantee that moving the last chunk out of a shard cleans up any leftover state, which it currently doesn't.

Generated at Thu Feb 08 05:35:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.