[SERVER-55165] inteldecimal version script should not be explicit dependency Created: 11/Mar/21  Updated: 29/Oct/23  Resolved: 02/Apr/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Daniel Moody Assignee: Daniel Moody
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
is caused by SERVER-49299 Intel decimal version script dependen... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Dev Platform 2021-04-05
Participants:

 Description   

In SERVER-49299, a workaround was put in place for ninja to correctly know about this dependency, but it used an explicit dependency (env.Depends) where it should have used an implicit dependency (target.add_to_implicit) which matches what SCons will use for build signatures. Using an explicit dependency will cause rebuilds because SCons will see the explicit dependency come and go, while its checking and executing the subst function in question.



 Comments   
Comment by Githook User [ 02/Apr/21 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-55165 fixed issue with inteldecimal script causing unnecessary rebuilds.
Branch: master
https://github.com/mongodb/mongo/commit/608b6537ffd35c6ed69674a1d6bd4e3eae4e531a

Generated at Thu Feb 08 05:35:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.