[SERVER-55211] Hello command should allow unknown fields Created: 15/Mar/21  Updated: 29/Oct/23  Resolved: 24/Mar/21

Status: Closed
Project: Core Server
Component/s: IDL
Affects Version/s: None
Fix Version/s: 5.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Samyukta Lanka Assignee: Huayu Ouyang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to DOCS-14291 Investigate changes in SERVER-53150: ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2021-04-05
Participants:

 Description   

SERVER-53150 changed hello/isMaster to not accept unknown parameters because all commands in API V1 are required to have 'strict: true' in IDL. However, we sometimes want drivers to advertise support for new features that old versions of the server don't know about via parameters in the hello/isMaster command. If we keep 'strict: true' with these commands, then older versions of the servers will fail to parse future requests since they don't recognize all of the parameters.

Since this ability to determine feature support has been useful in the past, it's worth preserving it. One way to do this would be to stop requiring that all commands in API V1 have 'strict: true' and change hello/isMaster to specify 'strict: false' in IDL.



 Comments   
Comment by Githook User [ 24/Mar/21 ]

Author:

{'name': 'Huayu Ouyang', 'email': 'huayu.ouyang@mongodb.com', 'username': 'huayu-ouyang'}

Message: SERVER-55211 Hello command should allow unknown fields
Branch: master
https://github.com/mongodb/mongo/commit/a9f7b3f77270b89eb51bd1673996c4ff6e2c8224

Comment by Samyukta Lanka [ 23/Mar/21 ]

Yep jeff.yemin, it is actively being worked on right now.

Comment by Jeffrey Yemin [ 23/Mar/21 ]

Hi samy.lanka the current behavior is making it difficult for drivers to implement support for load balancing, which requires a new field passed to hello. Can we get this work scheduled soon so we have it in latest builds?

Generated at Thu Feb 08 05:35:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.