[SERVER-55279] Commit queue message validation got tricked by merging multiple commits Created: 17/Mar/21 Updated: 19/Jul/21 Resolved: 19/Jul/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Jeffrey Zambory |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Operating System: | ALL | ||||||||||||||||
| Sprint: | DAG 2021-07-26 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Story Points: | 2 | ||||||||||||||||
| Description |
|
In this patch I managed to commit a message without a SERVER ticket by accident: https://github.com/mongodb/mongo/commit/075e51fefecc54e219c56e75c3ba08c993b5c187 It looks like it was because I batched multiple commits in one commit-queue merge:
That second-to-last line is the problem, and I think it validated the commit message as one big string: 'SERVER-54470 Use IDL to parse $collStats <- Add limited $collStats invocations to API Version 1' |
| Comments |
| Comment by Githook User [ 14/Jul/21 ] |
|
Author: {'name': 'Jeff Zambory', 'email': 'jeff.zambory@mongodb.com'}Message: |
| Comment by David Bradford (Inactive) [ 09/Jul/21 ] |
|
With DAG-1320 and EVG-14862, we should be able to get the list of commit messages as a json array instead of a concatenated string. Using that should make this possible. |
| Comment by Brooke Miller [ 18/Mar/21 ] |
|
We're going to backlog this for now given that this is a known limitation. If this fix is important to you and you would like us to consider prioritizing it for next quarter, please include this request in the next stakeholder spreadsheet (for April), to help us understand the priority and impact of this, alongside other quick-win requests for next quarter that your team would like us to consider. Also, it's worth mentioning that this would require us getting more granular commit data from Evergreen. |
| Comment by David Bradford (Inactive) [ 18/Mar/21 ] |
|
This is a known limitation with the validate script. If there are multiple commits in a patch build, the script does not have a way of knowing about the different commits or separating out their commit messages. We just get a concatenated string with all the commit message together. As a result, we can validate the first message, but are not able to validate any of the others. As a result, the validation is "best effort". |