[SERVER-55345] Relax commit duration assumption for noShards commit type in router_transaction_metrics.js Created: 19/Mar/21  Updated: 30/Sep/22  Resolved: 09/Sep/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 5.1.0-rc0, 4.2.23, 4.4.17, 5.0.11

Type: Bug Priority: Major - P3
Reporter: Jack Mulrow Assignee: Jonathan Lee
Resolution: Done Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Operating System: ALL
Backport Requested:
v5.1, v5.0, v4.4, v4.2
Sprint: Sharding 2021-09-20
Participants:
Linked BF Score: 0

 Description   

router_transaction_metrics.js assumes for every commit type that if a commit was successful, the corresponding successfulDurationMicros metric will be greater than 0. The no shards commit type doesn't require any network messages so it's possible to complete in less than a microsecond, which fails this test.

To avoid failures, the test should relax this assertion for just the no shards commit type. The other commit types all require at least one network message, so it should be safe to keep this assumption for them. 

 



 Comments   
Comment by Githook User [ 10/Aug/22 ]

Author:

{'name': 'Jonathan Lee', 'email': 'jonathan.lee@mongodb.com', 'username': 'jonatlee'}

Message: SERVER-55345 exclude noShards commit type from duration assertion in router_transaction_metrics.js

(cherry picked from commit 856e40338a080691f09986756529935683f86e47)
Branch: v4.2
https://github.com/mongodb/mongo/commit/d890505f7ec3a446393e77f1c270ccbaf0630c66

Comment by Githook User [ 09/Sep/21 ]

Author:

{'name': 'Jonathan Lee', 'email': 'jonathan.lee@mongodb.com', 'username': 'jonatlee'}

Message: SERVER-55345 exclude noShards commit type from duration assertion in router_transaction_metrics.js
Branch: master
https://github.com/mongodb/mongo/commit/856e40338a080691f09986756529935683f86e47

Generated at Thu Feb 08 05:36:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.