[SERVER-55367] add & to fix [-Wrange-loop-analysis] warning (xcode) Created: 19/Mar/21  Updated: 29/Oct/23  Resolved: 19/Mar/21

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service Arch 2021-03-22
Participants:

 Description   

PATH='/usr/local/bin:/opt/bin:/bin:/usr/bin' PATHOSX='/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/Library/Apple/usr/bin' /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ @build/ninja/mongo/db/s/config/sharding_catalog_manager_chunk_operations.o.rsp
src/mongo/db/s/config/sharding_catalog_manager_chunk_operations.cpp:514:21: error: loop variable 'shard' of type 'const mongo::BSONElement' creates a copy from type 'const mongo::BSONElement' [-Werror,-Wrange-loop-analysis]
    for (const auto shard : valuesElem.Array()) {
                    ^
src/mongo/db/s/config/sharding_catalog_manager_chunk_operations.cpp:514:10: note: use reference type 'const mongo::BSONElement &' to prevent copying
    for (const auto shard : valuesElem.Array()) {
         ^~~~~~~~~~~~~~~~~~
                    &



 Comments   
Comment by Githook User [ 19/Mar/21 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-55367 add & to fix xcode [-Wrange-loop-analysis] warning
Branch: master
https://github.com/mongodb/mongo/commit/e0c02385a21c388365b8908ebe33aaeeda3725e0

Comment by Billy Donahue [ 19/Mar/21 ]

I'm foregoing the whole reitveld upload for this 1-char change.

commit 9951097e2bd958dbd8494a6f96aff1a45fb4182a (HEAD -> SERVER-55180)
Author: Billy Donahue <billy.donahue@mongodb.com>
Date:   Fri Mar 19 13:24:03 2021 -0400
 
    add & to fix xcode [-Wrange-loop-analysis] warning
 
diff --git a/src/mongo/db/s/config/sharding_catalog_manager_chunk_operations.cpp b/src/mongo/db/s/config/sharding_catalog_manager_chunk_operations.cpp
index 3544004ded..c0397a95c2 100644
--- a/src/mongo/db/s/config/sharding_catalog_manager_chunk_operations.cpp
+++ b/src/mongo/db/s/config/sharding_catalog_manager_chunk_operations.cpp
@@ -511,7 +511,7 @@ std::vector<ShardId> getShardsOwningChunksForCollection(OperationContext* opCtx,
 
     const auto valuesElem = distinctResult.response.getField("values");
     std::vector<ShardId> shardIds;
-    for (const auto shard : valuesElem.Array()) {
+    for (const auto& shard : valuesElem.Array()) {
         shardIds.emplace_back(shard.String());
     }
     uassert(ErrorCodes::IncompatibleShardingMetadata,

Generated at Thu Feb 08 05:36:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.