[SERVER-55434] Log when Resharding Donor/Recipient coordinator updates are unsuccessful Created: 22/Mar/21 Updated: 29/Oct/23 Resolved: 17/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc3, 5.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Haley Connelly | Assignee: | Haley Connelly |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v5.0
|
||||
| Sprint: | Sharding 2021-06-28 | ||||
| Participants: | |||||
| Story Points: | 1 | ||||
| Description |
|
Since If the update is stale, it doesn't occur. For testing/ debugging purposes, it would be nice to log debug message when the update updates 0 documents (similar to what is done in the ReshardingCoordinatorService but logging instead of throwing since it is not a correctness issue) |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] | ||||||||||||||||
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! | ||||||||||||||||
| Comment by Githook User [ 17/Jun/21 ] | ||||||||||||||||
|
Author: {'name': 'Haley Connelly', 'email': 'haley.connelly@mongodb.com', 'username': 'haleyConnelly'}Message: (cherry picked from commit ec2596290a3a598b6f6ae1ec2097632f32fad563) | ||||||||||||||||
| Comment by Githook User [ 16/Jun/21 ] | ||||||||||||||||
|
Author: {'name': 'Haley Connelly', 'email': 'haley.connelly@mongodb.com', 'username': 'haleyConnelly'}Message: | ||||||||||||||||
| Comment by Haley Connelly [ 25/Mar/21 ] | ||||||||||||||||
|
Putting this in a comment since I already did it for debugging but editing the resharding recipient machine isn't necessarily within the scope of my current ticket. Inside updateCoordinatorDocument we uassertStatusOK(catalogClient->updateConfigDocument(....)) The updateConfigDocument returns a statusWith<Bool> which, Status::OK(), returns whether the update command's response update.n value is > 0. All we need to do is check if the value returned is false, and if so, log a debug message. eg
|