[SERVER-55527] Investigate use of --system-site-packages in venv setup in evergreen.yml Created: 25/Mar/21 Updated: 29/Oct/23 Resolved: 28/Apr/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Mikhail Shchatko |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tig-evgconfig | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | STM 2021-05-03 | ||||||||
| Participants: | |||||||||
| Story Points: | 1 | ||||||||
| Description |
|
We pass --system-site-packages to venv when creating our virtual python environment. I'm skeptical of this flag and whether it is a good idea to use it. With the v2 toolchain we had a lot of packages in the toolchain and it caused a lot of difficulty. For v3, most of them were removed. Is this perhaps a vestige of an earlier time that we can now do without? It appears it was introduced in
AC:
|
| Comments |
| Comment by Robert Guo (Inactive) [ 28/Apr/21 ] |
|
The back port should be applicable for all branches using the v3 toolchain. But it will not be a clean cherrypick so I'm hesitant to put in the effort. |
| Comment by Andrew Morrow (Inactive) [ 28/Apr/21 ] |
|
Can/should we backport this to any other branches? |
| Comment by Githook User [ 28/Apr/21 ] |
|
Author: {'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}Message: |
| Comment by Robert Guo (Inactive) [ 25/Mar/21 ] |
|
I'm adding this ticket to the evergreen.yml project; as part of enabling evergreen shell scripts to be run locally, we should ensure the Evergreen and local invocations for pip are identical if possible. Currently we recommend vanilla venv for local development on virtual workstations. |