[SERVER-55589] replSetMaintenance command does not take the RSTL Created: 29/Mar/21  Updated: 29/Oct/23  Resolved: 23/Jul/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 4.4.2
Fix Version/s: 4.2.18, 5.0.3, 4.4.9, 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Louis Williams Assignee: Vishnu Kaushik
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
related to DOCS-15125 [Server] compact no longer enters mai... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.0, v4.4, v4.2, v4.0
Sprint: Repl 2021-06-14, Repl 2021-06-28, Repl 2021-07-12, Repl 2021-07-26
Participants:
Linked BF Score: 174

 Description   

The replSetMaintenance command does not take the RSTL when changing replication state.

This is problematic for operations that make assertions based on replication state. Operations that hold the RSTL assume that the state does not change.

In one example, changing the replications state from SECONDARY to RECOVERYING in this way can fail an assertion in AutoGetCollectionForRead.



 Comments   
Comment by Githook User [ 14/Oct/21 ]

Author:

{'name': 'Vishnu Kaushik', 'email': 'vishnu.kaushik@mongodb.com', 'username': 'kauboy26'}

Message: SERVER-55589 read_reconfig.py load -> safe_load
Branch: v4.2
https://github.com/mongodb/mongo/commit/ab0980f5e5c20e11ebd2de0a40e515bf59defaef

Comment by Githook User [ 14/Oct/21 ]

Author:

{'name': 'Vishnu Kaushik', 'email': 'vishnu.kaushik@mongodb.com', 'username': 'kauboy26'}

Message: SERVER-55589 setMaintenanceMode should take RSTL in X mode
Branch: v4.2
https://github.com/mongodb/mongo/commit/db0a9bfd85178648b9a3ded39d999e25d8455e7d

Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 12/Aug/21 ]

Author:

{'name': 'Vishnu Kaushik', 'email': 'vishnu.kaushik@mongodb.com', 'username': 'kauboy26'}

Message: SERVER-55589 setMaintenanceMode should take RSTL in X mode
Branch: v4.4
https://github.com/mongodb/mongo/commit/62494948db7c6476536081f6ac40cf2d0ef223fe

Comment by Githook User [ 11/Aug/21 ]

Author:

{'name': 'Vishnu Kaushik', 'email': 'vishnu.kaushik@mongodb.com', 'username': 'kauboy26'}

Message: SERVER-55589 setMaintenanceMode should take RSTL in X mode
Branch: v5.0
https://github.com/mongodb/mongo/commit/a2872f24941ea324a5b46391abce5f91dfe2a29c

Comment by Githook User [ 23/Jul/21 ]

Author:

{'name': 'Vishnu Kaushik', 'email': 'vishnu.kaushik@mongodb.com', 'username': 'kauboy26'}

Message: SERVER-55589 setMaintenanceMode should take RSTL in X mode
Branch: master
https://github.com/mongodb/mongo/commit/fccf8ac6de56efaadea73a659b8b5ada12844a04

Comment by Louisa Berger [ 07/Jun/21 ]

Yup, that looks fine for us. 

Generated at Thu Feb 08 05:36:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.