[SERVER-55605] Create a git blame ignore revs file Created: 29/Mar/21  Updated: 29/Oct/23  Resolved: 11/Feb/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Judah Schvimer Assignee: Alex Neben
Resolution: Fixed Votes: 3
Labels: former-quick-wins
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-76794 Add git ignore revs file to mongo Closed
Related
is related to SERVER-73917 Update git blame ignore revs file Closed
Assigned Teams:
Server Development Platform
Backwards Compatibility: Fully Compatible
Participants:

 Description   

When git blaming there are various commits (like clang format upgrades) that can interfere with the blame. We should consider using git blame's "ignore revs" feature to hide these commits.



 Comments   
Comment by Githook User [ 11/Feb/23 ]

Author:

{'name': 'Alexander Neben', 'email': 'alexander.neben@mongodb.com', 'username': 'IamXander'}

Message: SERVER-55605 Ignore reformatting in git blame
Branch: master
https://github.com/mongodb/mongo/commit/ca07672b037d0a8ad517dbfa3e75020c3d6076ae

Comment by Daniel Gottlieb (Inactive) [ 05/Apr/21 ]

Would this be opt-in? As in there would be a file like etc/git/clang-format-revs and you would opt in by passing git blame --ignore-revs-file=etc/git/clang-format-revs ?

That was my reading. I intended to change my local environment to more automatically opt-in.

Comment by Andrew Morrow (Inactive) [ 30/Mar/21 ]

judah.schvimer - Would this be opt-in? As in there would be a file like etc/git/clang-format-revs and you would opt in by passing git blame --ignore-revs-file=etc/git/clang-format-revs? If so I think that is a rather good idea. I would however be somewhat opposed to doing this in a way that was enabled by default when cloning the repo: the investigative tools we have need to tell the whole truth unless explicitly asked not to. Presumably individual users could also permanently opt-in by customizing their local git configuration.

Comment by Daniel Gottlieb (Inactive) [ 30/Mar/21 ]

The two refactors I'm aware of:

Accompanying ignore revs file:

9c2ed42daa8fbbef4a919c21ec564e2db55e8d60
134a4083953270e8a11430395357fb70a29047ad

Generated at Thu Feb 08 05:36:56 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.