[SERVER-55616] Instances of ShardingDDLCoordinator are not throwing on NotPrimaryError nor ShutdownError Created: 30/Mar/21  Updated: 29/Oct/23  Resolved: 31/Mar/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 5.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Marcos José Grillo Ramirez Assignee: Marcos José Grillo Ramirez
Resolution: Fixed Votes: 0
Labels: PM-1965-Milestone-1, sharding-csrs-stepdown-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
is caused by SERVER-54587 Make create collection resilient to s... Closed
is caused by SERVER-54605 Make rename collection coordinator re... Closed
is caused by SERVER-54944 Make drop collection resilient to ste... Closed
is caused by SERVER-54945 Make drop database resilient to stepd... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2021-04-05
Participants:
Linked BF Score: 165

 Description   

The current implementation of the onCompletion callback on the instances of the ShardingDDLCoordinator are simply returning if there was a NotPrimaryError or ShutdownError category, if there is a write and the DDL operation fails because of a stepdown, then that error would not propagate to the router nor the operation retried, giving an ok:0 result to the user when actually the operation haven't finished. We should throw on those categories but leaving the current approach of not removing the coordinator document on those scenarios.



 Comments   
Comment by Githook User [ 31/Mar/21 ]

Author:

{'name': 'Marcos José Grillo Ramirez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}

Message: SERVER-55616 Remove coordinator document on create collection

... coordinator if the NotPrimaryError is not local
Branch: master
https://github.com/mongodb/mongo/commit/d9c4320491b60d3facf6b845a4575efb7f6f9670

Comment by Githook User [ 30/Mar/21 ]

Author:

{'name': 'Marcos José Grillo Ramirez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}

Message: SERVER-55616 Throw on NotPrimaryError and ShutdownError categories in ShardingDDLCoordinator instances
Branch: master
https://github.com/mongodb/mongo/commit/e41e20ebc940b47037bbce8a9af8ca1180c441c1

Generated at Thu Feb 08 05:36:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.