[SERVER-55643] Lint all files in the commit queue Created: 30/Mar/21  Updated: 25/May/21  Resolved: 20/Apr/21

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 5.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: Jeffrey Zambory
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Operating System: ALL
Sprint: DAG 2021-05-03
Participants:
Linked BF Score: 160
Story Points: 1

 Description   

At the moment, we only lint changed files in the commit queue, causing rare instances of lint errors being missed (see linked BF). It'll be nice to use the is_commit_queue expansion in Evergreen to have the "scons lint" function lint all the files instead.



 Comments   
Comment by Githook User [ 20/Apr/21 ]

Author:

{'name': 'Jeff Zambory', 'email': 'jeff.zambory@mongodb.com'}

Message: SERVER-55643: Lint all files in the commit queue
Branch: master
https://github.com/mongodb/mongo/commit/ae48215538d7ea7e0c0a7d29ef109b2c551878f3

Comment by David Bradford (Inactive) [ 05/Apr/21 ]

We specifically started only linting changed files in the commit-queue because linting all the files was taking too long to reasonable run it in the queue. Since then, however, we have split each linter into its own task and looking at the current "full" lint time that happens in the waterfall, it looks like we could safely go back to linting all the files (both in patch builds and in the commit queue).

Generated at Thu Feb 08 05:37:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.